Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2429 merge 'epithelial cell of alveolus of lung' #2535

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #2429 merge 'epithelial cell of alveolus of lung' into 'pulmonary alveolar epithelial cell'.
Also adds SubclassOf 'squamous epithelial cell' to 'pulmonary alveolar type 1' cell.
'pulmonary alveolar epithelial cell' is classified as 'squamous epithelial cell' because the alveolar epithelium in uberon is categorized as squamous, although pulmoanry alveolar cells type 2 are not squamous. Getting fixed in obophenotype/uberon#3350

Fixes #2429 merge 'epithelial cell of alveolus of lung' into 'pulmonary alveolar epithelial cell'.
Also adds SubclassOf 'squamous epithelial cell' to 'pulmonary alveolar type 1' cell.
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

github-actions bot commented Sep 2, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-02/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-02/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

epithelial cell of alveolus of lung http://purl.obolibrary.org/obo/CL_0010003

Removed

Added

pulmonary alveolar epithelial cell http://purl.obolibrary.org/obo/CL_0000322

Removed

Added

Copy link

github-actions bot commented Sep 2, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

obsolete epithelial cell of alveolus of lung http://purl.obolibrary.org/obo/CL_0010003

Removed

Added

pulmonary alveolar epithelial cell http://purl.obolibrary.org/obo/CL_0000322

Removed

Added

pulmonary alveolar type 2 cell http://purl.obolibrary.org/obo/CL_0002063

Added

@aleixpuigb aleixpuigb merged commit b85807c into master Sep 2, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the 2429_merge_alveolar_epi_cell branch September 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Merge] 'epithelial cell of alveolus of lung' should be merged to 'pulmonary alveolar epithelial cell'
2 participants