Update readme and check project against 23.10 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guillaume-haerinck <[email protected]>
|
Change is visible here : https://github.com/guillaume-haerinck/buongiorno-sample/tree/unified_readme |
| @@ -1,6 +1,5 @@ | |||
|
|
|||
| set(ENABLED_GEMS | |||
| Buongiorno | |||
| Atom | |||
There was a problem hiding this comment.
The correct gem name is below, had to remove this unused one to prevent a warning when registering project
Signed-off-by: guillaume-haerinck <[email protected]>
guillaume-haerinck
force-pushed
the
unified_readme
branch
from
e1f769f
to
1fa1f01
Compare
Signed-off-by: guillaume-haerinck <[email protected]>
Ulrick28
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take on an unified readme format used accross every O3DE samples (and checked that the project still runs correctly on the release of 23.10.3)
The goal being to make the samples more accessible to the users. Both by updating the project's readme, adding a version check and linking them in O3DE showcase and doc pages. Task tracked via this issue : o3de/o3de.org#2549