Physx5 updatePhysX Split support for PhysX5 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t endpoint URL - Add parameter to set the package name and rev - Update FindPhysX to FindPhysX5 - Fix escapement of the '$' character Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
- Add patching of physx5 from git to fix compilation error found in apple-clang 15 Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
…builds Signed-off-by: Steve Pham <[email protected]>
…ries Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
|
Unable to build through GHI due to current build scripts for PhysX not related to these changes. |
| 'SceneQuery_static_64', | ||
| 'SimulationController_static_64']: | ||
|
|
||
| for extra_static_lib_ext in ['.lib', '.pdb']: |
There was a problem hiding this comment.
Are we copying the .pdbs? Do we want to do that? Are they really big? Maybe we could output those to a separate place where they can be zipped and uploaded separate?
There was a problem hiding this comment.
This is a common scenario with a lot of these packages. Lets hold off on that until we come up with a general strategy for separate distribution of debug symbols for 3P packages and O3DE
AMZN-alexpete
approved these changes
Jan 30, 2024
Signed-off-by: Steve Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the PhysX 3rd Party script to support the o3de/sig-simulation#85.