MVPoly: improve from_variable and support "next row" in from_expr #2715
+305
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/improve-from-variable-implementation
branch
from
1549ac7
to
9eff145
Compare
From now, it will be using `Variable` from Kimchi/expr.
dannywillems
force-pushed
the
dw/improve-from-variable-implementation
branch
from
9eff145
to
fe76cbf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
==========================================
+ Coverage 72.54% 72.55% +0.01%
==========================================
Files 247 247
Lines 57699 57746 +47
==========================================
+ Hits 41856 41896 +40
- Misses 15843 15850 +7 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/improve-from-variable-implementation
branch
from
259ea0e
to
0c4a444
Compare
dannywillems
force-pushed
the
dw/improve-from-variable-implementation
branch
from
0c4a444
to
0b6dd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.