Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure in ipr request size #4844

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

octol
Copy link
Contributor

@octol octol commented Sep 8, 2024

Nightly build started failing due to a unit test using now(), changing the serialized size. Fixed to use a fixed date.

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:06am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:06am

@octol octol added this to the Wedel milestone Sep 8, 2024
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed this won't do as it will break in few months again anyway

@octol
Copy link
Contributor Author

octol commented Sep 9, 2024

Good catch by @jstuczyn, this is due to the timestamp using now()

@octol octol changed the title Fix test failure in ipr request size that suddenly appeared Fix test failure in ipr request size Sep 9, 2024
@octol octol merged commit 7e40207 into develop Sep 9, 2024
25 checks passed
@octol octol deleted the jon/fix-test-fail-in-ipr branch September 9, 2024 10:01
@octol octol mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants