Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply device inactivity threshold at initial import time #632

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

Andrew-Dickinson
Copy link
Member

Apply the same thresholding logic to abandon date for devices at initial import time as we do on continuous UISP imports, to prevent devices being prematurely marked inactive

Also add missing newline to -------- separator

@Andrew-Dickinson Andrew-Dickinson changed the title Apply device inactivity threshold at initial import time @Andrew-Dickinson Apply device inactivity threshold at initial import time Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (7b21c21) to head (9774499).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #632   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          79       79           
  Lines        3235     3235           
=======================================
  Hits         3047     3047           
  Misses        188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-Dickinson Andrew-Dickinson enabled auto-merge (squash) October 12, 2024 17:41
@Andrew-Dickinson Andrew-Dickinson merged commit 46d6597 into main Oct 12, 2024
10 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/device-inactive-threshold-at-import branch October 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants