Fix: NYC addresses are sent to random New England towns #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 75 75
Lines 3087 3087
=======================================
Hits 2903 2903
Misses 184 184 ☔ View full report in Codecov by Sentry. |
|
Merging as this is import script related and Willard is still on vacation |
WillNilges
pushed a commit
that referenced
this pull request
Oct 12, 2024
* Fix: NYC addresses are sent to random new england towns * Add typo fix for "sreet"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a persisent import script issue, but it seemed to only happen for badly formatted addresses so I never looked that carefully into it. However today I noticed it was happening for perfectly valid YAYB addresses, and decided to try to fix it. I think this is gonna make things a great deal better