Add map data endpoints #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Dickinson
force-pushed
the
map-endpoint
branch
from
10a8682
to
7277ea9
Compare
|
I wonder why they are slow. |
|
Outside this scope, but we could also host our own map pretty easily. |
I think it’s the serialization. DB scans are pretty fast, but to generate 1.7 MB of JSON is actually quite a bit of string parsing / manipulation
Agreed, but one thing at a time |
andybaumgar
approved these changes
Jan 28, 2024
Andrew-Dickinson
force-pushed
the
map-endpoint
branch
from
7277ea9
to
2281fba
Compare
Andrew-Dickinson
force-pushed
the
map-endpoint
branch
from
2281fba
to
626e77d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds endpoints that are compatible with the data format used on the website map.
The data is not strictly equal, since there is some data loss during our import process this is mostly due to NN/install number shenanigans (status fields being another example). However, these new map endpoints are in the format expected by the map, and spot checks confirm that the data is isomorphic.
Due to the lack of pagination, these endpoints are quite slow (10+ seconds in some cases), but this should hopefully ease integration on the other side. This latency is fine because the data is packaged into JS code asynchronously, users get a pre-computed artifact.
We still need to make changes on the map backend in order to get this JSON data packaged up into the Javascript code, but hopefully that is essentially trivial with the format I'm providing here.
Also adds unit tests to cover most cases of the logic in new endpoints