- Upgrade to njre v1.4.0 (#95)

- Fix issue when package called from ES Module by using njre installPath option
nvuillam · Aug 29, 2024 · 300ca41 · 300ca41
1 parent 28b80f5
commit 300ca41
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## [4.1.1] 2024-08-30
+
+- Upgrade to njre v1.4.0
+- Fix issue when package called from ES Module by using njre installPath option
+
 ## [4.1.0] 2024-08-20
 
 - Upgrade to MegaLinter v8

diff --git a/lib/java-caller.js b/lib/java-caller.js
@@ -274,11 +274,8 @@ class JavaCaller {
 
             // Install appropriate java version using njre
             const njre = require("njre");
-            const njreOptions = { type: javaTypeToInstall };
-            const prevRequireMainFilename = require.main.filename; // hack require.main.filename to njre installs java where we want
-            require.main.filename = packageJson;
+            const njreOptions = { type: javaTypeToInstall, installPath: packageJson };
             const installDir = await njre.install(javaVersionToInstall, njreOptions);
-            require.main.filename = prevRequireMainFilename; // unhack require.main.filename
             console.log(`Installed Java ${javaTypeToInstall} ${javaVersionToInstall} in ${installDir}...`);
 
             // Call again this method: now matching java version will be found :)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,7 +37,7 @@
   "dependencies": {
     "debug": "^4.3.4",
     "fs-extra": "^11.1.1",
-    "njre": "^1.2.1",
+    "njre": "^1.4.0",
     "semver": "^7.5.4"
   },
   "devDependencies": {