Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Fixed json parsing logic for remote endpoints. Now it … #9

Merged

Conversation

SkyeHoefling
Copy link
Contributor

…properly handles the JSON string array, before it just split on ','

Fixes #8

I just added the 1 .tsx file into this PR to limit the noise of the PR. @nvisionative should I update the PR with the built code prior to accepting?

…properly handles the JSON string array, before it just split on ','
Copy link
Member

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-poindexter david-poindexter merged commit 6d4c2cb into nvisionative:master Sep 6, 2018
@david-poindexter david-poindexter added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Sep 6, 2018
@david-poindexter
Copy link
Member

@ahoefling this really goes back to the discussion on #3 - I went ahead and merged. We do need to come up with a game plan moving forward. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants