Skip to content

fix validation for access control policy #906

fix validation for access control policy

fix validation for access control policy #906

name: Acceptance Test cases
on:
pull_request:
repository_dispatch:
types: [ok-to-test-command]
jobs:
Acceptance-Tests:
runs-on: self-hosted
if: github.event_name == 'repository_dispatch'
steps:
- run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
- run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!"
- run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
- name: Check out repository code
uses: actions/checkout@v2
with:
ref: 'refs/pull/${{ github.event.client_payload.pull_request.number }}/merge'
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.17
- name: Acceptance test cases
run: |
args="${{ github.event.client_payload.slash_command.args }}"
providers=(${args})
index=0
n=${#providers[@]}
runFlag=""
for provider in $args
do
if [ "$provider" = "foundation" ]
then
runFlag+="TestAccFoundation*"
elif [ "$provider" = "foundation_central" ]
then
runFlag+="TestAccFC*"
elif [ "$provider" = "karbon" ]
then
runFlag+="TestAccKarbon*"
elif [ "$provider" = "pc" ]
then
runFlag+="TestAccNutanix*"
elif [ "$provider" = "era" ]
then
runFlag+="TestAccEra*"
else
echo "Invalid provider=$provider given in arguments."
exit 1
fi
if [ $index -lt $((n-1)) ]
then
runFlag+="|"
fi
index=$((index+1))
done
export TESTARGS='-run="'$runFlag'"'
echo "TESTARGS = $TESTARGS"
echo '${{ secrets.FOUNDATION_CONFIG }}' > test_foundation_config.json
echo '${{ secrets.PC_CONFIG }}' > test_config.json
${{ secrets.ACCEPTANCE_TEST_ARGS }} make testacc
- name: Code Coverage Check
if: ${{ always() }}
run: |
echo "Code coverage: Checking if code coverage is above threshold..."
export TESTCOV_THRESHOLD=50
echo "Threshold: $TESTCOV_THRESHOLD %"
totalCoverage=`go tool cover -func=c.out | grep total | grep -Eo '[0-9]+\.[0-9]+'`
echo "Current test coverage : $totalCoverage %"
if (( $(echo "$totalCoverage $TESTCOV_THRESHOLD" | awk '{print ($1 > $2)}') )); then
echo "CODE_COVERAGE_OUTPUT=Line code coverage is $totalCoverage" >> $GITHUB_ENV
echo "Line coverage is $totalCoverage"
else
echo "CODE_COVERAGE_OUTPUT=Current line coverage ($totalCoverage) is below threshold ($TESTCOV_THRESHOLD). Kindly add more acceptance tests." >> $GITHUB_ENV
echo "Current coverage ($totalCoverage) is below threshold ($TESTCOV_THRESHOLD)."
fi
- run: echo "Success!"
- run: echo "🍏 This job's status is ${{ job.status }}."
# Update the comment back
- name: Update comment
uses: peter-evans/create-or-update-comment@v1
if: ${{ always() }}
with:
comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
body: |
>Acceptance test run status: ${{ job.status }}
>${{ env.CODE_COVERAGE_OUTPUT }}
reaction-type: hooray
# Update check run for Acceptance Test
- uses: actions/github-script@v5
id: update-check-run
if: ${{ always() }}
env:
number: ${{ github.event.client_payload.pull_request.number }}
job: ${{ github.job }}
# Conveniently, job.status maps to https://developer.github.com/v3/checks/runs/#update-a-check-run
conclusion: ${{ job.status }}
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { data: pull } = await github.rest.pulls.get({
...context.repo,
pull_number: process.env.number
});
const ref = pull.head.sha;
const { data: checks } = await github.rest.checks.listForRef({
...context.repo,
ref
});
const check = checks.check_runs.filter(c => c.name === process.env.job);
if (check.length == 0) {
return "Check is not present, ignoring this step."
}
const { data: result } = await github.rest.checks.update({
...context.repo,
check_run_id: check[0].id,
status: 'completed',
conclusion: process.env.conclusion
});
return result;