Update ntnx_acps.py #476
Open
Update ntnx_acps.py #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding missing check for new context list items, not just removing extra old ones
Bump up Ansible core version to 2.15.0 due to EOL of 2.14.0 (nutanix#478)
| @@ -421,6 +421,10 @@ def check_acp_idempotency(old_spec, update_spec): | |||
| if context not in update_context_list: | |||
| return False | |||
|
|
|||
| for context in update_context_list: | |||
There was a problem hiding this comment.
Thanks for pointing it out. Btw can this be solved by comparing length of old and new context list in initially instead of this new loop added?
There was a problem hiding this comment.
it could possibly be solved that way, but what if the length of the list doesn't change but the contents do? i.e. remove one bad entry and add a new replacement one
There was a problem hiding this comment.
Previous for loop should take care of that. It will not find that one bad entry from old_context_list in new_context_list, which will detect the change in context lists.
And length check initially will detect new additions to context_lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing check for new context list items, not just removing extra old ones