HF Token Fixes #47
Merged
HF Token Fixes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavrissh
previously approved these changes
Jan 5, 2024
gavrissh
reviewed
Jan 5, 2024
gavrissh
reviewed
Jan 5, 2024
llm/kubeflow_inference_run.py
Outdated
| "model directory", | ||
| is_dir=True, | ||
| ) | ||
|
|
||
| if not model_params["is_custom"]: | ||
| if not model_info["repo_version"]: | ||
| model_info["repo_version"] = model_params["repo_version"] |
There was a problem hiding this comment.
also setting first then updating immediately? Doesn't look clean
There was a problem hiding this comment.
changed this to set it directly in the function
gavrissh
reviewed
Jan 5, 2024
llm/kubeflow_inference_run.py
Outdated
|
|
||
| check_if_path_exists( | ||
| os.path.join( | ||
| mount_path, |
There was a problem hiding this comment.
have a variable / helper method with path_to_model_dir set. No need to add them comma separated multiple times
There was a problem hiding this comment.
created a new function
gavrissh
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: