-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HF Token Fixes #47
HF Token Fixes #47
Conversation
llm/kubeflow_inference_run.py
Outdated
"model directory", | ||
is_dir=True, | ||
) | ||
|
||
if not model_params["is_custom"]: | ||
if not model_info["repo_version"]: | ||
model_info["repo_version"] = model_params["repo_version"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also setting first then updating immediately? Doesn't look clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed this to set it directly in the function
llm/kubeflow_inference_run.py
Outdated
|
||
check_if_path_exists( | ||
os.path.join( | ||
mount_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a variable / helper method with path_to_model_dir set. No need to add them comma separated multiple times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created a new function
Changes: