-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fong Yih Jie] iP #487
base: master
Are you sure you want to change the base?
[Fong Yih Jie] iP #487
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 556af3f - Browse repository at this point
Copy the full SHA 556af3fView commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5fe9e8b - Browse repository at this point
Copy the full SHA 5fe9e8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9196067 - Browse repository at this point
Copy the full SHA 9196067View commit details -
Configuration menu - View commit details
-
Copy full SHA for 229e2b6 - Browse repository at this point
Copy the full SHA 229e2b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bba21b5 - Browse repository at this point
Copy the full SHA bba21b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5853db - Browse repository at this point
Copy the full SHA a5853dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 451c8c4 - Browse repository at this point
Copy the full SHA 451c8c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f055d3 - Browse repository at this point
Copy the full SHA 9f055d3View commit details
Commits on Aug 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 96a42de - Browse repository at this point
Copy the full SHA 96a42deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d025c3 - Browse repository at this point
Copy the full SHA 1d025c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f44176 - Browse repository at this point
Copy the full SHA 6f44176View commit details -
Configuration menu - View commit details
-
Copy full SHA for d66ebf3 - Browse repository at this point
Copy the full SHA d66ebf3View commit details
Commits on Aug 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4ba2c39 - Browse repository at this point
Copy the full SHA 4ba2c39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f01979 - Browse repository at this point
Copy the full SHA 5f01979View commit details -
Merge pull request #1 from nus-cs2103-AY2223S1/add-gradle-support
Add Gradle support
Configuration menu - View commit details
-
Copy full SHA for e403f32 - Browse repository at this point
Copy the full SHA e403f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c5047d - Browse repository at this point
Copy the full SHA 2c5047dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eff73f - Browse repository at this point
Copy the full SHA 3eff73fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3a012d - Browse repository at this point
Copy the full SHA f3a012dView commit details
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b0612c7 - Browse repository at this point
Copy the full SHA b0612c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f4be4 - Browse repository at this point
Copy the full SHA 70f4be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f83e41 - Browse repository at this point
Copy the full SHA 8f83e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for b19f0f7 - Browse repository at this point
Copy the full SHA b19f0f7View commit details -
Merge branch 'branch-A-CodingStandard'
# Conflicts: # src/main/java/duke/Storage.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java
Configuration menu - View commit details
-
Copy full SHA for fd033e9 - Browse repository at this point
Copy the full SHA fd033e9View commit details -
# Conflicts: # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java
Configuration menu - View commit details
-
Copy full SHA for 6e94db0 - Browse repository at this point
Copy the full SHA 6e94db0View commit details
Commits on Sep 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 29e0808 - Browse repository at this point
Copy the full SHA 29e0808View commit details
Commits on Sep 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1c27bd - Browse repository at this point
Copy the full SHA f1c27bdView commit details
Commits on Sep 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 12236b0 - Browse repository at this point
Copy the full SHA 12236b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fff3258 - Browse repository at this point
Copy the full SHA fff3258View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20ada3f - Browse repository at this point
Copy the full SHA 20ada3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1bd19f - Browse repository at this point
Copy the full SHA f1bd19fView commit details -
Included some assertions in Parser, Task and Storage class. These assertions should help to flag out bugs in these classes during runtime.
Configuration menu - View commit details
-
Copy full SHA for 02a0d9b - Browse repository at this point
Copy the full SHA 02a0d9bView commit details -
Improved on quality of code according to code quality guide. Removed instances of magic number and revised bad variable naming. This makes the code easier to read.
Configuration menu - View commit details
-
Copy full SHA for 16a6b77 - Browse repository at this point
Copy the full SHA 16a6b77View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e8e21 - Browse repository at this point
Copy the full SHA c5e8e21View commit details -
Merge branch 'master' into branch-A-CodeQuality
# Conflicts: # src/main/java/duke/Storage.java
Configuration menu - View commit details
-
Copy full SHA for 2884196 - Browse repository at this point
Copy the full SHA 2884196View commit details -
Merge pull request #4 from fongyj/branch-A-CodeQuality
Branch a code quality
Configuration menu - View commit details
-
Copy full SHA for 5017077 - Browse repository at this point
Copy the full SHA 5017077View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2083aa - Browse repository at this point
Copy the full SHA d2083aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a9d966 - Browse repository at this point
Copy the full SHA 1a9d966View commit details -
Optimised duplicate task checking
Used a HashSet to store task strings for duplicate checking. Checking for duplicate via a HashSet is faster than checking for duplicates by iterating through an ArrayList.
Configuration menu - View commit details
-
Copy full SHA for 5e510ca - Browse repository at this point
Copy the full SHA 5e510caView commit details
Commits on Sep 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e21f213 - Browse repository at this point
Copy the full SHA e21f213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11a7a10 - Browse repository at this point
Copy the full SHA 11a7a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef6bfb - Browse repository at this point
Copy the full SHA 1ef6bfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfa63ae - Browse repository at this point
Copy the full SHA cfa63aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a9eec1 - Browse repository at this point
Copy the full SHA 5a9eec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1816df3 - Browse repository at this point
Copy the full SHA 1816df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7913543 - Browse repository at this point
Copy the full SHA 7913543View commit details -
Configuration menu - View commit details
-
Copy full SHA for 218d762 - Browse repository at this point
Copy the full SHA 218d762View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9ff7b7 - Browse repository at this point
Copy the full SHA e9ff7b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f62af - Browse repository at this point
Copy the full SHA e4f62afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1390bfc - Browse repository at this point
Copy the full SHA 1390bfcView commit details
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2a3e9c4 - Browse repository at this point
Copy the full SHA 2a3e9c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 611d04a - Browse repository at this point
Copy the full SHA 611d04aView commit details -
Configuration menu - View commit details
-
Copy full SHA for df9bcb1 - Browse repository at this point
Copy the full SHA df9bcb1View commit details
Commits on Sep 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b1277d5 - Browse repository at this point
Copy the full SHA b1277d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 352de77 - Browse repository at this point
Copy the full SHA 352de77View commit details -
Find command used to search using toString method of the tasks. This will include (by:...) and (at:...) in the search. This will mean that "find y" will return all deadlines and "find (" will return all deadlines and events.
Configuration menu - View commit details
-
Copy full SHA for cf229e0 - Browse repository at this point
Copy the full SHA cf229e0View commit details -
Fix storage and duplicate check implementation
Storage used to save only after bye command. Now save after every modification to task list. Also updated storage file chick.txt to not store uncheck command as it is redundant. Duplicate check was missing in the implementation of removing the task from duplicate check after deleting the task from task list.
Configuration menu - View commit details
-
Copy full SHA for d4b0f6e - Browse repository at this point
Copy the full SHA d4b0f6eView commit details -
Fix storage and duplicate check implementation
Storage used to save only after bye command. Now save after every modification to task list. Also updated storage file chick.txt to not store uncheck command as it is redundant. Duplicate check was missing in the implementation of removing the task from duplicate check after deleting the task from task list.
Configuration menu - View commit details
-
Copy full SHA for 48cd30d - Browse repository at this point
Copy the full SHA 48cd30dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01a7b7c - Browse repository at this point
Copy the full SHA 01a7b7cView commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ec2c08d - Browse repository at this point
Copy the full SHA ec2c08dView commit details