Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bryan Lim Jing Xiang] iP #484

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

[Bryan Lim Jing Xiang] iP #484

wants to merge 82 commits into from

Commits on Jul 31, 2022

  1. Add Gradle support

    @damithc
    damithc authored and damithc committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    556af3f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Set up skeletal version of Duke

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    cbdb453 View commit details
    Browse the repository at this point in the history

  2. Revert "Set up skeletal version of Duke" 

    This reverts commit cbdb453.
    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e4406e0 View commit details
    Browse the repository at this point in the history

  3. Set up skeletal version of Duke

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    295c10a View commit details
    Browse the repository at this point in the history

  4. Revert "Set up skeletal version of Duke" 

    This reverts commit 295c10a.
    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e904640 View commit details
    Browse the repository at this point in the history

  5. Set up skeletal version of Duke

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    48e4d08 View commit details
    Browse the repository at this point in the history

  6. Refactor text formatting to separate class

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b0343fe View commit details
    Browse the repository at this point in the history

  7. Add list that stores/display text entered by user

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    747d7ef View commit details
    Browse the repository at this point in the history

  8. Add Task that can be marked/unmarked

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2a968a6 View commit details
    Browse the repository at this point in the history

  9. Refactor formatting of multiple lines to new function

    @bryanljx
    bryanljx committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ef2e2c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Tidy variables and return types in Task

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    1af53d8 View commit details
    Browse the repository at this point in the history

  2. Revert "Tidy variables and return types in Task" 

    This reverts commit 1af53d8.
    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    92f6033 View commit details
    Browse the repository at this point in the history

  3. Add Task subclasses for todo, event, deadline

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    8d0ffd1 View commit details
    Browse the repository at this point in the history

  4. Update TaskList to match changes to Task

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    c71124f View commit details
    Browse the repository at this point in the history

  5. Update duke to handle todo, event, deadline

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    4d6e203 View commit details
    Browse the repository at this point in the history

  6. Fix regex to match / instead of "

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5aa7417 View commit details
    Browse the repository at this point in the history

  7. Update comments to match regex change

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    f06be8e View commit details
    Browse the repository at this point in the history

  8. Update test script and files to automate testing

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5ce35d8 View commit details
    Browse the repository at this point in the history

  9. Add error handling

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0f14bf5 View commit details
    Browse the repository at this point in the history

  10. Add delete functionality to TaskList

    @bryanljx
    bryanljx committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    41a199b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Add encoding to Tasks classes and group them into task package

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8a5ae31 View commit details
    Browse the repository at this point in the history

  2. Refactor TextFormatter to Ui class placed in util package

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    87f307f View commit details
    Browse the repository at this point in the history

  3. Refactor and move TaskList to tasklist package

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    52cc632 View commit details
    Browse the repository at this point in the history

  4. Refactor DukeException and add unknown task encoding exception

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    1695b30 View commit details
    Browse the repository at this point in the history

  5. Add storage class

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ed33f84 View commit details
    Browse the repository at this point in the history

  6. Add Parser class to util pkg

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    308e105 View commit details
    Browse the repository at this point in the history

  7. Add Command abstract class

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    794e7d0 View commit details
    Browse the repository at this point in the history

  8. Move execution logic to relevant Command subclasses

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2929330 View commit details
    Browse the repository at this point in the history

  9. Update Duke to match previous changes

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9301f1f View commit details
    Browse the repository at this point in the history

  10. Add data/saveFile.txt to gitIgnore

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5af5b35 View commit details
    Browse the repository at this point in the history

  11. Edit Duke to only parse /by or /at for Deadline and Event respectively

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    c9c36a4 View commit details
    Browse the repository at this point in the history

  12. Add invalid datetime format exceptions

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    c4e868d View commit details
    Browse the repository at this point in the history

  13. Add Date classes

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f874ae4 View commit details
    Browse the repository at this point in the history

  14. Update tasklist and tasks to use date classes

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8d840af View commit details
    Browse the repository at this point in the history

  15. Update Duke to match date changes

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e752e41 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'branch-Level-7'

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    be66be1 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'branch-Level-8'

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2e414b7 View commit details
    Browse the repository at this point in the history

  18. Move date classes to date pkg

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    df1bf3c View commit details
    Browse the repository at this point in the history

  19. Add encoding for Deadline/Event

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b934421 View commit details
    Browse the repository at this point in the history

  20. Fix regression in exception when resolving merge conflict

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    480e5b7 View commit details
    Browse the repository at this point in the history

  21. Update Parser to proper parse Deadline/Event

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ea5a64b View commit details
    Browse the repository at this point in the history

  22. Fix Storage not creating new save file if dir exists

    @bryanljx
    bryanljx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    caba951 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Merge branch 'add-gradle-support'

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    0d61b90 View commit details
    Browse the repository at this point in the history

  2. Add stubs for Task class

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    b3a1a2f View commit details
    Browse the repository at this point in the history

  3. Add unit tests for TaskList

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    183db00 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for Task subclasses

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    090246c View commit details
    Browse the repository at this point in the history

  5. Update build.gradle on main class classname

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    ad95c76 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary println statement

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    5c28d8e View commit details
    Browse the repository at this point in the history

  7. Remove symbol from error messages

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    42eaf49 View commit details
    Browse the repository at this point in the history

  8. Add find functionality to TaskList

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    4274021 View commit details
    Browse the repository at this point in the history

  9. Add find command

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    5c0c0f4 View commit details
    Browse the repository at this point in the history

  10. Update Parse to parse find command

    @bryanljx
    bryanljx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2856898 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. Set up checkstyle with Gradle

    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    dad6c94 View commit details
    Browse the repository at this point in the history

  2. Fix coding style violations

    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    c5739ea View commit details
    Browse the repository at this point in the history

  3. Add javadocs 

    Note that this branch is done after the A-CodingStandards when auto format on save in intelliJ was set up so there might be some files that were formatted as well.
    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    7e0f0c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-A-JavaDoc'

    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    01b8d7d View commit details
    Browse the repository at this point in the history

  5. Add javadocs for FindSearchTextCommand

    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    d3659f7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'branch-A-CodingStandard'

    @bryanljx
    bryanljx committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    5299d13 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Add javadocs for Find functions

    @bryanljx
    bryanljx committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    1d817e1 View commit details
    Browse the repository at this point in the history

  2. Add import for @DisplayName annotation

    @bryanljx
    bryanljx committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    ec31e4c View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Add javaFX to application

    @bryanljx
    bryanljx committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1f43423 View commit details
    Browse the repository at this point in the history

  2. Modify Command classes to store/return output message

    @bryanljx
    bryanljx committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6791a4f View commit details
    Browse the repository at this point in the history

  3. Add gui elements

    @bryanljx
    bryanljx committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e960b7d View commit details
    Browse the repository at this point in the history

  4. Update Duke and Ui according to gui changes

    @bryanljx
    bryanljx committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    02ea18b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge tag 'Level-10'

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c356bd8 View commit details
    Browse the repository at this point in the history

  2. Add equals method for Date Time classes

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    61e5dec View commit details
    Browse the repository at this point in the history

  3. Add equals method for Task classes

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    726da86 View commit details
    Browse the repository at this point in the history

  4. Implement check for duplicated tasks in TaskList

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fdce8bb View commit details
    Browse the repository at this point in the history

  5. Update AddTaskCommand to account for duplicated tasks

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    49f846a View commit details
    Browse the repository at this point in the history

  6. Rectify error in date format for INVALID_EVENT_DATETIME_FORMAT 

    Date format for event datetime is `yyyy-mm-dd hh:mm:ss hh:mm:ss`,
not `yyyy-mm hh:mm:ss hh:mm:ss  hh:mm:ss`. This has been rectified
in this commit.
    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e920688 View commit details
    Browse the repository at this point in the history

  7. Add assertions after validating args where appropriate 

    Added validations after validating arguments/format
for Todo arguments, EventDateTime, and DeadlineDateTime.
    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a704a9d View commit details
    Browse the repository at this point in the history

  8. Refactor string concatenation to use StringBuilder instead 

    There were a few cases where String concatenation was used within
a loop instead of StringBuilder, which is not ideal due to
performance reasons. This was fixed in this commit.
    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    88006fa View commit details
    Browse the repository at this point in the history

  9. Enable assertions in gradle file

    @bryanljx
    bryanljx committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6f82246 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge pull request #1 from bryanljx/branch-A-Assertions 

    Add Assertions
    @bryanljx
    bryanljx authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    cce9961 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from bryanljx/branch-A-CodeQuality 

    Improve code quality
    @bryanljx
    bryanljx authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    4baa0c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. Merge branch 'branch-C-DetectDuplicates'

    @bryanljx
    bryanljx committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    e44b2e3 View commit details
    Browse the repository at this point in the history

  2. Add screenshot of app

    @bryanljx
    bryanljx committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    45d6b53 View commit details
    Browse the repository at this point in the history

  3. Update User Guide

    @bryanljx
    bryanljx committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    ce3cfa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Update tests

    @bryanljx
    bryanljx committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    54e1d55 View commit details
    Browse the repository at this point in the history

  2. Update build.gradle

    @bryanljx
    bryanljx committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ff6fdad View commit details
    Browse the repository at this point in the history

  3. Update user guide

    @bryanljx
    bryanljx committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    cec587b View commit details
    Browse the repository at this point in the history

  4. Update gradle.build

    @bryanljx
    bryanljx committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    af1cd6e View commit details
    Browse the repository at this point in the history