[Gernene Tan] iP #290

Gernene · 2022-01-28T14:34:07Z

Duke

Create

Deadlines
Events
Todo Items
Check off items
Mark tasks as not done

Fast
Simple
Easy

I am Duke!

public void start(Stage stage) {
        try {
            FXMLLoader fxmlLoader = new FXMLLoader(Main.class.getResource("/view/MainWindow.fxml"));
            AnchorPane ap = fxmlLoader.load();
            Scene scene = new Scene(ap);
            scene.getStylesheets().add(Main.class.getResource("/css/style.css").toExternalForm());
            String home = System.getProperty("user.home");
            Path directory = Paths.get(home, "Documents", "duke");
            Path filePath = Paths.get(home, "Documents", "duke", "data.txt");
            duke = new Duke(directory, filePath);
            stage.setScene(scene);
            fxmlLoader.<MainWindow>getController().setDuke(duke);
            stage.show();
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

list

😄

Download here

IP requirement

Add asserts

Refactor Parser.java

junrong98

Overall, I found your code easy to read and they follow the Java coding standard provided. However, some files such as Parser.java were difficult to read due to the nested if-else statements. Consider encapsulating some similar statements into a function to improve readability.

junrong98 · 2022-02-03T02:03:19Z

src/main/java/duke/task/Task.java

+    return isMarked;
+  }
+
+  public boolean contains(String str) {


Perhaps a change to the function name to sound more like a boolean?

Suggested change

public boolean contains(String str) {

public boolean hasString(String str) {

junrong98 · 2022-02-03T02:07:39Z

src/main/java/duke/task/Todo.java

+
+public class Todo extends Task {
+
+  public Todo(String description, boolean status) {


Perhaps a change to the argument name to sound more like a boolean? I noticed this issue occurring in classes extending task.

Suggested change

public Todo(String description, boolean status) {

public Todo(String description, boolean isMarked) {

junrong98 · 2022-02-03T02:09:37Z

src/main/java/duke/task/Event.java

+public class Event extends Task {
+
+  private LocalDate date;
+
+  public Event(String description, boolean status, LocalDate date) {
+    super(description, status);
+    this.date = date;
+  }
+
+  public Event(String description, LocalDate date) {
+    this(description, false, date);
+  }
+
+  public String toString() {
+    return String.format("[E][%s] %s (at: %s)", super.isMarked(), super.getDescription(), DateTimeFormatter.ofPattern("MMM d yyyy"));
+  }
+}


Perhaps add header comments for the class and public functions. I noticed the same issue for classes extending Task and Command?

EvaderFati

Overall your code closely follows the coding standard and is nicely constructed. Only some small writing problems to fix.

EvaderFati · 2022-02-04T15:40:50Z

src/main/java/duke/command/AddCommand.java

+        this.task = task;
+    }
+
+    public void execute(TaskList tasks, Ui ui, Storage storage) {


Although it is not required, it is recommended to add the '@ Override' annotation. https://stackoverflow.com/questions/1005898/should-i-add-an-override-annotation-when-implementing-abstract-methods-in-java

EvaderFati · 2022-02-04T15:44:08Z

src/main/java/duke/DukeException.java

+
+public class DukeException extends Exception {
+
+  public DukeException(String message) {


According to the stupid Coding standard, should it be better to indent this line as 4 spaces instead of 2?

markbiju

Excellent attempt at following coding standard with absolutely minimal coding standard violations

markbiju · 2022-02-06T15:50:15Z

src/main/java/duke/task/Event.java

+
+  private LocalDate date;
+
+  public Event(String description, boolean status, LocalDate date) {


Perhaps you could name status to be more boolean-sounding? :)

markbiju · 2022-02-06T15:55:47Z

src/main/java/duke/Parser.java

+     * @return UnmarkCommand instance.
+     */
+    public Command parseUnmarkCommand(String fullCommand) {
+        String dataString = fullCommand.replaceFirst("unmark ", "");


Commendable discretion shown here to differentiate when to use camelCase and when to use PascalCase.

markbiju · 2022-02-06T15:57:37Z

src/main/java/duke/Storage.java

+                assert data[1].equals("true") || data[1].equals("false") : throw DukeException("Invalid file input");
+                Boolean status = Boolean.parseBoolean(data[1]);
+                String text = data[2];
+                if (data[0].equals("T")) {


The if-else class of statements should have the following form:
if (condition) {
statements;
} else if (condition) {
statements;
} else {
statements;
}

markbiju · 2022-02-06T15:58:43Z

src/main/java/duke/task/Deadline.java

+  }
+
+  public String toString() {
+    return String.format("[D][%s] %s (by: %s)", super.isMarked(), super.getDescription(), DateTimeFormatter.ofPattern("MMM d yyyy"));


Perhaps this line is rather long and would benefit from a line break?

Branch wk5

Unit tests for Parser and Storage are incomplete. Adding more test methods helps ensure code quality. Let's add unit tests methods to ensure storage and command line data is interpreted correctly.

Prepare duke for release

Polish

Fix dialog text wrapping

Polish

Gernene added 24 commits January 21, 2022 14:59

Complete Level 1

beb8f9a

Complete level 2

9ded4e3

Finish level 3

e67c0af

Complete level 4

034bc63

Complete level 5

0ba0124

Complete level 6

07c0ff2

Finish level 7

c210aea

Finish level 8

fd0d7fe

Merge branch-Level-8

2d7bf73

Add more OOP

1ebfdd4

Reorganize code

d7fb640

Set up gradle and JUnit

7c14c12

Resolve errors

9b70cc4

Fix gradle problems

9592aef

Enable junit tests

f3f959a

Add comments

1083b65

Tweak formatting

57fb550

Find tasks that match keyword

3d3ccda

Merge branch 'branch-A-CodingStandard'

e49809d

IP requirement

Resolve merge conflicts

413e3d5

Add asserts

e420544

Refactor Parser.java

73ba75e

Merge pull request #1 from Gernene/branch-A-Assertions

a6652d2

Add asserts

Merge pull request #2 from Gernene/branch-A-CodeQuality

e3c6824

Refactor Parser.java

junrong98 reviewed Feb 3, 2022

View reviewed changes

Gernene added 4 commits February 3, 2022 10:53

Fix code standard violations

80768c0

Configure checkstyle

8058a73

Add UI support

ba2ef08

Add GUI

0a6cfde

EvaderFati reviewed Feb 4, 2022

View reviewed changes

Gernene added 2 commits February 5, 2022 16:11

Fix coding standard violations

fbf9dba

Fix test coding standard violations

8638af5

markbiju reviewed Feb 6, 2022

View reviewed changes

Gernene added 22 commits February 9, 2022 10:09

Display UI

3e03b92

Merge pull request #3 from Gernene/branch-wk5

bd95e01

Branch wk5

Add contacts

33819f5

Fix bugs

1f2f28b

Save list to harddisk

40cb69d

Style GUI

be87d3e

Refine unit tests for Parser and Storage

cd16506

Unit tests for Parser and Storage are incomplete. Adding more test methods helps ensure code quality. Let's add unit tests methods to ensure storage and command line data is interpreted correctly.

Create user guide

8d23565

Merge pull request #5 from Gernene/polish

3fb5bae

Prepare duke for release

Polish minor details

3b68386

Fix text wrap on dialog box

94a58b4

Merge pull request #6 from Gernene/polish

287e0df

Polish

Fix text-wrapping issue

6f7bcde

Exit UI on command

df43ef4

Merge pull request #7 from Gernene/polish

af39b16

Fix dialog text wrapping

Update build.gradle for win compatibility

a114595

Improve contacts functionality

73378ef

Improve error handling

5e6721e

Update GUI

c6b1b2e

Change button color

d6fc622

Update UG

e24a712

Merge pull request #9 from Gernene/polish

c1d909a

Polish

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gernene Tan] iP #290

[Gernene Tan] iP #290

Gernene commented Jan 28, 2022 •

edited

Loading

junrong98 left a comment

junrong98 Feb 3, 2022

junrong98 Feb 3, 2022

junrong98 Feb 3, 2022

EvaderFati left a comment

EvaderFati Feb 4, 2022

EvaderFati Feb 4, 2022

markbiju left a comment

markbiju Feb 6, 2022

markbiju Feb 6, 2022

markbiju Feb 6, 2022

markbiju Feb 6, 2022

	public boolean contains(String str) {
	public boolean hasString(String str) {


		public class Todo extends Task {

		public Todo(String description, boolean status) {


		public class DukeException extends Exception {

		public DukeException(String message) {


		private LocalDate date;

		public Event(String description, boolean status, LocalDate date) {

[Gernene Tan] iP #290

Are you sure you want to change the base?

[Gernene Tan] iP #290

Conversation

Gernene commented Jan 28, 2022 • edited Loading

Duke

junrong98 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EvaderFati left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markbiju left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gernene commented Jan 28, 2022 •

edited

Loading