Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Porter URIs #542

Closed

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Jul 2, 2024

Type of PR:

  • Feature

Required reviews:

  • 1

Notes for reviewers:

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 0f18985
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/6683dc07b88ceb0008139684

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 0f18985
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/6683dc07d334310008b00504

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review July 2, 2024 10:58
tapir: 'https://porter-tapir.nucypher.community',
oryx: 'https://porter-oryx.nucypher.community',
mainnet: 'https://porter.nucypher.io',
tapir: 'https://porter-tapir.nucypher.io',
lynx: 'https://porter-lynx.nucypher.community',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are switching, should we just switch all? i.e. also switch lynx - cc @KPrasch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but currently https://porter-lynx.nucypher.io/ doesn't work

Copy link
Member

@derekpierre derekpierre Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I just mean that we shouldn't merge this before making that happen. can explore setting up porter-lynx.nucypher.io before potentially merging. Not the end of the world of course if we merge without it, but then we should file a follow-up issue.

@piotr-roslaniec piotr-roslaniec added the do not merge Open for review but do not merge please label Jul 2, 2024
@piotr-roslaniec piotr-roslaniec mentioned this pull request Jul 30, 2024
7 tasks
@derekpierre
Copy link
Member

Will be fixed via #555 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Open for review but do not merge please
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants