Duration Sampling #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
force-pushed
the
duration-sampling
branch
2 times, most recently
from
615b4fb
to
68eb709
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #67 +/- ##
================================================
+ Coverage 0 87.31% +87.31%
================================================
Files 0 18 +18
Lines 0 867 +867
================================================
+ Hits 0 757 +757
- Misses 0 110 +110 ☔ View full report in Codecov by Sentry. |
derekpierre
requested review from
KPrasch,
cygnusv,
theref,
vzotova,
manumonti and
piotr-roslaniec
vzotova
approved these changes
Apr 29, 2024
piotr-roslaniec
approved these changes
Apr 30, 2024
…/get_ursulas endpoint.
…ode if duration > 0.
…unts are managed by a separate test account manager instead of testerchain.
…longer because it wants the ursula ping check to complete before looking for other ursulas, so that the list of staking providers returned is mostly deterministic for the same random seed value. Reduce stagger timout since ping already has a connection timeout of 3.05s from `nucypher`.
derekpierre
force-pushed
the
duration-sampling
branch
from
d400076
to
c1b7e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on nucypher/nucypher#3491.
Before merging this PR there should be an update to the Pipfile to use
nucypherbranchv7.3.xafter PR 3491 is merged.Type of PR:
Required reviews:
What this does:
Allows optional
durationparameter to be specified for the/bucket_samplingand/get_ursulasPorter endpoints.Issues fixed/closed:
Why it's needed:
Notes for reviewers: