Relock dependencies with nucypher v7.1.x so that lynx uses sepolia
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
changed the title
nucypher v7.1.x.nucypher v7.1.x so that lynx uses sepolia
7 tasks
derekpierre
force-pushed
the
lynx-sepolia
branch
from
15beb3f
to
24cb753
Compare
|
This code is currently running on porter-lynx. |
cygnusv
reviewed
Jan 8, 2024
| eip712==0.2.2 ; python_version >= '3.8' and python_version < '4' | ||
| eth-abi==4.2.1 ; python_full_version >= '3.7.2' and python_version < '4' | ||
| eth-account==0.8.0 ; python_version >= '3.6' and python_version < '4' | ||
| eth-ape==0.6.27 ; python_version >= '3.8' and python_version < '4' |
There was a problem hiding this comment.
pointing out that this is relocking eth-ape to latest version. I assume this doesn't matter for porter, but I was under the impression there were some issues in tests with versions > 0.6.19
There was a problem hiding this comment.
Indeed. There are with nucypher-contracts, and last I checked the "issue" was that the tests take much longer. However, we haven't had that issue in Porter tests.
KPrasch
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Relock dependencies with
nucypherv7.1.x that includes nucypher/nucypher#3376.Issues fixed/closed:
Why it's needed:
Notes for reviewers: