Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates + nginx cleanup #57

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Dec 12, 2023

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

  • Remove nginx docker information
  • Added tests for timeout capping/adjustments.
  • Update dated documentation.

Issues fixed/closed:

Fixes #56

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR addresses a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

…ecifically support in the repos. Porter operators can choose how they do TLS/SSL individually.
@derekpierre derekpierre self-assigned this Dec 12, 2023
@derekpierre derekpierre changed the title [WIP] Python 3.12 + Documentation updates Documentation updates Dec 12, 2023
@derekpierre derekpierre changed the title Documentation updates Documentation updates + nginx cleanup Dec 12, 2023
Added unit test for timeout adjustment.
@derekpierre derekpierre marked this pull request as ready for review December 12, 2023 20:22
@derekpierre
Copy link
Member Author

Decided to document the timeouts in the README, and have docs.threshold.network point to the report for more information. Felt like too much to add for docs.threshold.network.

Adjusting timeouts is not really something I expect will be used, it's just there as a fallback in case there are real issues in public instances.

Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✌️

tests/test_porter_configure_timeout.py Outdated Show resolved Hide resolved
@derekpierre derekpierre merged commit f0f8828 into nucypher:development Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Add test to confirm max timeout cannot be exceeded
3 participants