Validity checks #38
Merged
Validity checks #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
force-pushed
the
validity-checks
branch
from
e5fe1ad
to
dab1a40
Compare
theref
reviewed
Jan 17, 2023
piotr-roslaniec
commented
Jan 18, 2023
piotr-roslaniec
commented
Jan 18, 2023
piotr-roslaniec
commented
Jan 18, 2023
piotr-roslaniec
commented
Jan 18, 2023
This was referenced Jan 19, 2023
piotr-roslaniec
force-pushed
the
validity-checks
branch
from
0d5d274
to
6d51e71
Compare
piotr-roslaniec
force-pushed
the
validity-checks
branch
from
3a6e32c
to
991685e
Compare
Benchmark for a8b951fClick to view benchmark
|
piotr-roslaniec
force-pushed
the
validity-checks
branch
from
991685e
to
da92818
Compare
Benchmark for 190d8bfClick to view benchmark
|
5 tasks
# Conflicts: # .github/workflows/workspace.yml # ferveo/benches/benchmarks/pvdkg.rs # ferveo/src/dkg/pv.rs # ferveo/src/vss/pvss.rs # tpke/src/ciphertext.rs # tpke/src/combine.rs # tpke/src/context.rs # tpke/src/decryption.rs # tpke/src/key_share.rs # tpke/src/lib.rs
theref
reviewed
Jan 24, 2023
|
@theref Added missing benchmarks, please see the dropdown in the OP. |
theref
approved these changes
Jan 30, 2023
piotr-roslaniec
force-pushed
the
validity-checks
branch
from
ca83a9e
to
dd9e458
Compare
cygnusv
reviewed
Feb 1, 2023
ferveo/src/vss/pvss.rs
Outdated
Comment on lines
159
to
160
| // Y = \sum_i y_i \alpha^i | ||
| // A = \sum_i a_i \alpha^i |
There was a problem hiding this comment.
Suggested change
| // Y = \sum_i y_i \alpha^i | |
| // A = \sum_i a_i \alpha^i |
I think these lines are outdated, there's no alpha_i anymore
ferveo/src/vss/pvss.rs
Outdated
| @@ -335,6 +338,28 @@ mod test_pvss { | |||
| assert!(!pvss.verify_optimistic()); | |||
| } | |||
|
|
|||
| /// Check that if PVSS shares are tempered with, the full verification fails | |||
There was a problem hiding this comment.
Suggested change
| /// Check that if PVSS shares are tempered with, the full verification fails | |
| /// Check that if PVSS shares are tampered with, the full verification fails |
| // Optimistic verification should not catch this issue | ||
| assert!(bad_pvss.verify_optimistic()); | ||
| // Full verification should catch this issue | ||
| assert!(!bad_pvss.verify_full(&dkg)); |
tpke/src/ciphertext.rs
Outdated
| pub fn check_ciphertext_validity<E: PairingEngine>( | ||
| c: &Ciphertext<E>, | ||
| aad: &[u8], | ||
| ) -> bool { | ||
| ) -> Result<()> { | ||
| let g_inv = E::G1Prepared::from(-E::G1Affine::prime_subgroup_generator()); |
There was a problem hiding this comment.
Can we take this from SetupParams?
There was a problem hiding this comment.
Yes, we just need to pass g_inv through a lot of places. See my latest commit for details.
cygnusv
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e5fe1adverify_fullBenchmarks
Ciphertext validity
PVSS Validity (optimistic vs full verification)