BugFix ansible-collections#453 modifying the config acls.py for sourc…

…e/destination so that port-group is not direct opton of src/dest instead added port-group to argument of port_protocol
ntl-afzaalarif · Nov 17, 2023 · 872a669 · 872a669
1 parent 81f66b3
commit 872a669
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/plugins/module_utils/network/iosxr/config/acls/acls.py b/plugins/module_utils/network/iosxr/config/acls/acls.py
@@ -374,8 +374,6 @@ def _compute_src_dest(dir_dict):
                 cmd += "host {0} ".format(dir_dict["host"])
             elif "net_group" in dir_dict:
                 cmd += "net-group {0} ".format(dir_dict["net_group"])
-            elif "port_group" in dir_dict:
-                cmd += "port-group {0} ".format(dir_dict["port_group"])
             elif "prefix" in dir_dict:
                 cmd += "{0} ".format(dir_dict["prefix"])
             else:
@@ -386,11 +384,15 @@ def _compute_src_dest(dir_dict):
 
             if "port_protocol" in dir_dict:
                 protocol_range = dir_dict["port_protocol"].get("range")
+                port_group = dir_dict["port_protocol"].get("port_group")
                 if protocol_range:
                     cmd += "range {0} {1} ".format(
                         protocol_range["start"],
                         protocol_range["end"],
                     )
+                elif port_group:
+                    for key, value in iteritems(dir_dict["port_protocol"]):
+                        cmd += "port-group {1} ".format(key, value)
                 else:
                     for key, value in iteritems(dir_dict["port_protocol"]):
                         cmd += "{0} {1} ".format(key, value)