[TypeScript Reference] Attempt to sync netflix typescript changes into working branch (NO MERGE) #292
Conversation
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
| @@ -0,0 +1,101 @@ | |||
| // The config object that gets passed around to instantiate the server | |||
There was a problem hiding this comment.
No major changes here. Just some stronger typings and some different ways for generating the config.
| @@ -0,0 +1,256 @@ | |||
| import express = require("express"); | |||
There was a problem hiding this comment.
This is a new edition that adds support for reading raw files from an S3. Not sure if migrating this is totally necessary.
Totally agree! This code is also likely more out of date than if we switched things over again now. |
MSeal
changed the title
|
I changed the title to better reflect the state of the code changes. I think we should leave this open while doing typescript improvments as a references? |
|
Yep. This comment has more info about our action plan. |
I have not made this branch run yet, just doing a dump of changes made on the netflix fork internally somewhere it can be evaluated for use in commuter open source. The code changed pretty dramatically in how it handled typescript assets and organized some things so I didn't bother with trying to merge git histories. Likely many of the changes need to use the current master code instead, but we can discuss what to do with the branch at our next sync meeting.