Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit code for draw if the column doesn't exist #612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't emit code for draw if the column doesn't exist #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/tikzplotlib/_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,21 +194,25 @@ def draw_pathcollection(data, obj):
ls = None

if add_individual_color_code:
draw_options.extend(
[
"scatter",
"visualization depends on={value \\thisrow{draw} \\as \\drawcolor}",
"visualization depends on={value \\thisrow{fill} \\as \\fillcolor}",
"scatter/@pre marker code/.code={%\n"
+ " \\expanded{%\n"
+ " \\noexpand\\definecolor{thispointdrawcolor}{RGB}{\\drawcolor}%\n"
+ " \\noexpand\\definecolor{thispointfillcolor}{RGB}{\\fillcolor}%\n"
+ " }%\n"
+ " \\scope[draw=thispointdrawcolor, fill=thispointfillcolor]%\n"
+ "}",
"scatter/@post marker code/.code={%\n \\endscope\n}",
]
)
draw_options.append("scatter")
if "draw" in labels or "fill" in labels:
if "draw" in labels:
draw_options.append("visualization depends on={value \\thisrow{draw} \\as \\drawcolor}")
if "fill" in labels:
draw_options.append("visualization depends on={value \\thisrow{fill} \\as \\fillcolor}")
scope_vars = ", ".join(f"{var}=thispoint{var}color" for var in ("draw", "fill") if var in labels)
draw_options.extend(
[
"scatter/@pre marker code/.code={%\n"
+ " \\expanded{%\n"
+ (" \\noexpand\\definecolor{thispointdrawcolor}{RGB}{\\drawcolor}%\n" if "draw" in labels else "")
+ (" \\noexpand\\definecolor{thispointfillcolor}{RGB}{\\fillcolor}%\n" if "fill" in labels else "")
+ " }%\n"
+ " \\scope[" + scope_vars + "]%\n"
+ "}",
"scatter/@post marker code/.code={%\n \\endscope\n}",
]
)

# "solution" from
# <https://github.com/matplotlib/matplotlib/issues/4672#issuecomment-378702670>
Expand Down