Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use action to update comment with check ressults #106

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

bateau84
Copy link
Contributor

@bateau84 bateau84 commented Aug 24, 2023

use edumserrano/find-create-or-update-comment to update existing comment
instead of creating new when checks are run.

@bateau84 bateau84 requested a review from a team as a code owner August 24, 2023 13:39
@bateau84 bateau84 requested review from umglurf, djbuster and arott and removed request for a team August 24, 2023 13:39
@stigok
Copy link
Contributor

stigok commented Aug 25, 2023

Du burde teste denne først. Det er en grunn til at jeg brukte den bool emoji-funksjonen. Er ikke sikkert exit-code er String type lenger heller.

@bateau84
Copy link
Contributor Author

hvordan går jeg frem for å teste denne?

@stigok
Copy link
Contributor

stigok commented Aug 29, 2023

hvordan går jeg frem for å teste denne?

Lager et PR i et Terraform-repo som referer til denne jobben med tag @update_check_comment

@bateau84 bateau84 force-pushed the update_check_comment branch 3 times, most recently from 948eb31 to 0d1e68f Compare October 6, 2023 13:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Format: ✔️ Init: ✔️ Validate: ✔️

check

use edumserrano/find-create-or-update-comment to update existing comment
instead of creating new when checks are run.
@bateau84
Copy link
Contributor Author

bateau84 commented Oct 6, 2023

Har testet denne på sandbox clusteret nå, å det ser ut til å fungere: https://github.com/nrkno/plattform-terraform-sandbox-config/pull/358

@bateau84 bateau84 merged commit 5792655 into main Oct 6, 2023
15 checks passed
@bateau84 bateau84 deleted the update_check_comment branch October 6, 2023 13:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants