Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lock icon variants to match design #300

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

haakemon
Copy link
Contributor

@haakemon haakemon commented Jul 17, 2024

The icons previously had 2px whitespace on top and 1px whitespace on bottom. This has been switched around so that there is now 1px whitespace on top and 2px whitespace on bottom. This makes the icons look better aligned when used alone, and also matches how they look in figma.

fixes #261
closes #274

The icons previously had 2px whitespace on top and 1px whitespace on bottom. This has been switched around
so that there is now 1px whitespace on top and 2px whitespace on bottom. This makes the icons look better aligned
when used alone.
@haakemon haakemon marked this pull request as ready for review July 17, 2024 05:56
Copy link
Contributor

@ingvilddev ingvilddev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@haakemon haakemon merged commit 437b949 into master Jul 17, 2024
1 check passed
@haakemon haakemon deleted the feat/update-lock-icons branch July 17, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated icons: nrk-lock (+variants) nrk-lock icon seems misaligned
2 participants