Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zlib encoding #1888

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add Zlib encoding #1888

merged 1 commit into from
Aug 19, 2024

Conversation

markpeek
Copy link
Contributor

The FreeBSD hypervisor (bhyve) has a built-in VNC server supporting both Raw and Zlib. Adding Zlib encoding to noVNC will reduce the data transferred between the server and client. And will add this encoding for other use cases as well.

Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some minor cleanup that can be done, and then we can merge this!

core/decoders/zlib.js Outdated Show resolved Hide resolved
core/decoders/zlib.js Outdated Show resolved Hide resolved
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your contribution!

@CendioOssman CendioOssman merged commit c6c8e5e into novnc:master Aug 19, 2024
11 checks passed
@samhed samhed added the feature label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants