Implemented blocking_event_loop for osx #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR, great work! |
birhburh
added a commit
to birhburh/miniquad
that referenced
this pull request
Aug 11, 2024
- Reverted macos.rs to this implementation: not-fl3#443 (it's probably better compare changes with this PR than with latest commit to understand what was added additionally) - Now using own NSView with NSOpenGLContext instead of NSOpenGLView - For metal backend using redraw instead setNeedsDisplay, because somehow it reduces cpu usage (Cannot find info about enabling vsync like this in MTKView docs) - Fixed freezing on resize by drawing in draw_rect that called during "live resize"™. I don't like this approach, but it blocks main event loop while resizing, so it will not be some kind of concurency of opengl stuff i think - Reducing CPU usage when window is occluded - Added comments to hacky places, there are lots of them imo Fixes: - not-fl3#455 - not-fl3#470
not-fl3
pushed a commit
that referenced
this pull request
Aug 11, 2024
- Reverted macos.rs to this implementation: #443 (it's probably better compare changes with this PR than with latest commit to understand what was added additionally) - Now using own NSView with NSOpenGLContext instead of NSOpenGLView - For metal backend using redraw instead setNeedsDisplay, because somehow it reduces cpu usage (Cannot find info about enabling vsync like this in MTKView docs) - Fixed freezing on resize by drawing in draw_rect that called during "live resize"™. I don't like this approach, but it blocks main event loop while resizing, so it will not be some kind of concurency of opengl stuff i think - Reducing CPU usage when window is occluded - Added comments to hacky places, there are lots of them imo Fixes: - #455 - #470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented window loop for OSX (as far as I underastand NSApplication run works like this)
And also implemented blocking_event_loop for osx (based on this pull request: #437)