Fixed forced modal pause of the application when resizing or moving on Windows #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Current implementation will force a pause on resizing or moving a window on Windows. This pause is modal: it will block all activity in main thread, including all polling inside update (which can result in as severe consequences as disconnection of multiplayer games!).
The solution
The solution was long-and-length discussed in 8-years-spanning thread at SDL repo (!) and finally met final, safe solution in this SDL 2.30 PR at 2023, November.
This is a port of that solution into miniquad. It will only affect Windows platform.