Remade diagrams #147
Merged
Remade diagrams #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm bringing this in from my `diagrams-test` branch.
From diagrams.net, I'd originally exported at 200% zoom, to roughly match the original jpgs. Looking at the markdown page, these seemed gigantic, essentially taking up a printed page. The new versions are exported at 100% zoom.
Oops, I brought the images but not the markdown from `diagrams-test` branch. Fixed.
Adding id attributes - e.g. `#fig-03-01` before figures.
To do: * some renaming to less terse, more greppable filenames (diagram, not u) * exporting PNG and SVG files * deleting redundant attempts
Skipping figure 17.7 for now - lost in browser crash?
Filling gaps: 6.1, 6.2, 16.2, 17.7
|
I'm willing to try going forward for this. We should test on multiple browser/OS combinations. Thank you for the effort. |
|
Note: Fig 17.5 still needs work. |
|
Re: 17.5 - Turning some images into markdown tables is still a WIP branch - see #136. It might have stalled. I realized I have a Raspberry Pi, with only the basic Ubuntu fonts installed. I'm going to skim the diagrams there. |
|
On the Linux machine, the diagrams are perfectly legible and in place. (Everything looks odd at 500% zoom.) 18.05 had inconsistent fonts, but in all, it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I puttered around on draw.io / diagrams.net . I think they're an improvement, but perhaps not the final word. I included svg (vector) and png files.
The text in svg might be an issue - embedding fonts (which might be the default?) or turning the letters into lines and curves could fix that. Those would be a matter of re-exporting with different settings, after verifying the fix. I ... dunno. Maybe roll forward with this until it breaks somewhere?
Some background in #139 .