Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plot_substack_cc to use CC store #153

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Update plot_substack_cc to use CC store #153

merged 2 commits into from
Jul 20, 2023

Conversation

carlosgjs
Copy link
Collaborator

@carlosgjs carlosgjs commented Jul 19, 2023 •
edited
Loading

We need to update the plotting functions to use the store abstraction instead of reading ASDF files directly. This will enable using other formats, such as Zarr.

Changes:

  • Support read operations on the StackStore
  • Add unit tests for StackStore
  • Update plotting module functions to use stores
  • Update notebooks

@carlosgjs carlosgjs temporarily deployed to github-pages July 19, 2023 19:51 — with GitHub Actions Inactive
@carlosgjs carlosgjs temporarily deployed to github-pages July 19, 2023 20:42 — with GitHub Actions Inactive
@carlosgjs carlosgjs mentioned this pull request Jul 20, 2023
Merged
niyiyu added a commit that referenced this pull request Jul 20, 2023
@niyiyu
reverting plotting module for #153
1be485f
niyiyu added a commit that referenced this pull request Jul 20, 2023
@niyiyu
reverting plotting module for #153
50801ad
aniketfadia96
aniketfadia96 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@aniketfadia96 aniketfadia96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carlosgjs carlosgjs merged commit bb4d2ca into master Jul 20, 2023
45 checks passed
@carlosgjs carlosgjs deleted the carlosg/plotstores branch July 20, 2023 21:20
@carlosgjs carlosgjs mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketfadia96 aniketfadia96 aniketfadia96 approved these changes

@kuanfufeng kuanfufeng Awaiting requested review from kuanfufeng

@uwcdc uwcdc Awaiting requested review from uwcdc

@mdenolle mdenolle Awaiting requested review from mdenolle

@niyiyu niyiyu Awaiting requested review from niyiyu

@chengxinjiang chengxinjiang Awaiting requested review from chengxinjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosgjs @aniketfadia96