Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TLS Certificate based Authentication #207

Merged

Conversation

sudiptosarkar
Copy link
Contributor

Added support for TLS Certificate based Authentication to be able to get the token with client TLS Certificate, as is required according to #206

@aviadhahami
Copy link
Collaborator

@sudiptosarkar please fix the above issues so we can continue :)

Copy link
Collaborator

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting pr fixes

@sudiptosarkar sudiptosarkar force-pushed the features/tlsAuthentication branch 2 times, most recently from e8b37b5 to 7eb0a00 Compare May 12, 2023 03:03
@sudiptosarkar
Copy link
Contributor Author

@aviadhahami, Done. Please approve the workflows.

@aviadhahami
Copy link
Collaborator

@sudiptosarkar please fix workflow errors 🙇

@sudiptosarkar
Copy link
Contributor Author

@sudiptosarkar please fix workflow errors bow

@aviadhahami, Done. Verified with npm run lint this time.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #207 (370ba51) into master (61273fb) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          141       141           
=========================================
  Hits           141       141           
Impacted Files Coverage Δ
src/commands.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@aviadhahami aviadhahami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aviadhahami aviadhahami merged commit b275a5a into nodevault:master May 14, 2023
@aviadhahami
Copy link
Collaborator

thx for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants