util: add fast path for Latin1 decoding #55275
Open
+133
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
mertcanaltin
requested review from
anonrig and
joyeecheung
and removed request for
anonrig
targos
reviewed
Oct 5, 2024
mertcanaltin
force-pushed
the
dev-178
branch
2 times, most recently
from
2dd0714
to
b871573
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55275 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 652
Lines 186612 186641 +29
Branches 36062 36068 +6
==========================================
+ Hits 165001 165003 +2
- Misses 14885 14910 +25
- Partials 6726 6728 +2
|
RafaelGSS
approved these changes
Oct 5, 2024
|
Can you update benchmarks as well? |
anonrig
reviewed
Oct 5, 2024
anonrig
requested changes
Oct 5, 2024
anonrig
requested changes
Oct 5, 2024
| @@ -443,6 +446,10 @@ function makeTextDecoderICU() { | |||
| return decodeUTF8(input, this[kIgnoreBOM], this[kFatal]); | |||
| } | |||
|
|
|||
| if (this[kLatin1FastPath]) { | |||
There was a problem hiding this comment.
After Line 443, we need this, since we don't support options.stream on the fast path.
this[kLatin1FastPath] &&= !(options?.stream)
There was a problem hiding this comment.
I will apply it as you say, thank you.
lib/internal/encoding.js
Outdated
| @@ -443,6 +446,10 @@ function makeTextDecoderICU() { | |||
| return decodeUTF8(input, this[kIgnoreBOM], this[kFatal]); | |||
| } | |||
|
|
|||
| if (this[kLatin1FastPath]) { | |||
| return decodeLatin1(input); | |||
There was a problem hiding this comment.
You should support ignore bom, and fatal values as well.
There was a problem hiding this comment.
I made an update covering this, thank you
Co-authored-by: Yagiz Nizipli <[email protected]>
I wonder if this is the right place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a fast path for Latin1 (windows-1252) decoding to improve performance. This change avoids using the slower ICU-based decoding for Latin1 and instead utilizes a direct approach, similar to the fast path implemented for UTF-8.
nodejs/performance#178