deps: update libuv to 1.49.0 #55114
Open
deps: update libuv to 1.49.0 #55114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
libuv
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55114 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186576 186573 -3
Branches 36049 36061 +12
=======================================
+ Hits 164960 164967 +7
+ Misses 14889 14867 -22
- Partials 6727 6739 +12
|
github-actions
bot
removed
the
request-ci
RafaelGSS
approved these changes
Sep 25, 2024
lpinca
approved these changes
Sep 25, 2024
github-actions
bot
removed
the
request-ci
|
Lots of test failures, likely related. |
github-actions
bot
removed
the
request-ci
This reverts commit 42e659c.
As now the `SQPOLL` ring used in the libuv io_uring implementation is disabled by default. Also modify `UvMightBeUsingIoUring()` to just handle the case where `Node.js` is dynamically linked to a `libuv` version which has the `SQPOLL` ring enabled.
santigimeno
force-pushed
the
santi/libuv_v1.49.0
branch
from
a5345bf
to
90fa04e
Compare
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added also a couple of commits to partially revert the changes that fixed GHSA-vr4q-vx84-9g5x, as it's no longer relevant now that the
SQPOLLring is disabled by default.Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0
/cc @tniessen