tools: add WPT updater for specific subsystems

[mertcanaltin]

a WPT updater that specifically targets the url subsystem for more controlled and focused updates.

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[mertcanaltin]

thanks for your suggestions

[RedYetiDev]

Here are my opinions

[RedYetiDev]

I also feel like this could be moved to a dep_updater file.

[RedYetiDev]

By the way, I'm trying to update the WPT files in #54468.

IMO this could be done via

git node wpt <...>

Because the README.md file also needs to be updated.

[mertcanaltin]

By the way, I'm trying to update the WPT files in #54468.

IMO this could be done via

git node wpt <...>

Because the README.md file also needs to be updated.

Do you have a suggestion, would that be enough for this?

- Name: Update README.md file
        Run: |
            # Update the README.md file with the new WPT version
            # Assuming you have a script or command to do this
            ./scripts/update-readme.sh ‘${{{ env.NEW_VERSION }}’

      - Name: Commit to Changes
        Run: |
            git config --global user.name ‘Node.js GitHub Bot’
            git config --global user.email ‘[email protected]’
            git add test/fixtures/wpt README.md
            git commit -m ‘test: Update WPT to ${{{ env.NEW_VERSION }} and update README.md’

[RedYetiDev]

In my opinion, the entire WPT update process could be moved to a dep-updater script, using git node for each section. But, there are a lot of cases where updating these tests cause problems (just look at the errors in my PR), so maybe keeping it manual is good?

I'm not sure.

[panva]

In general I don't think updating WPTs automatically is a good idea. I can't find the issue now but I believe we've already had that discussion in the past, that's not to say we can't have it again... So:

• The way to update WPTs is through the git node wpt ... command from node-core-utils, not checking out the WPT repo and copying over files
• WPTs have dependencies in resources, interfaces, or generally a new folder that is not part of the checkout and requires manual intervention
• Pulling in new WPTs often makes new WPTs fail, that also requires manual intervention
• There are tentative WPTs that are not tied to a finished spec change, that will fail too
• If there was an automated process then WPTs should be updated by their subsystem, not all at once, but that again raises an issue when that subsystem WPT change requires to pull in a file from a different directory that also needs to be updated
• Some WPT subsystems currently cannot be updated (e.g. WebCryptoAPI) because we don't have a way to conditionally mark tests as failing depending on the system they run on, in WebCryptoAPI's case - test: update wpt test for WebCryptoAPI #54127, test,crypto: update WebCryptoAPI WPT #52222 (comment), RHEL's linked OpenSSL makes some vectors pass that don't pass anywhere else.

In my opinion a sensible way to update WPTs would be to pull a WPT subsystem from upstream (using git node wpt ...), run it, if it passes - open a PR, if it fails - have a keepalive issue where pending WPT updates are tracked.

FWIW this could also be hooked into the daily wpt job that runs the most up to date WPT checkout for the purpose of uploading the current state to wpt.io.

Remember that WPTs may very well fail for a long time when they are a) tentative or b) require a semver-major change to pass.

[panva]

cc @nodejs/web-standards

[legendecas]

yeah, we had discussion at #50567.

[mertcanaltin]

I'm closing this place, thank you very much for the comments

[panva]

mertcanaltin/node-auto-test/actions/runs/10972255885/job/30468306292 I did a test run here and it seems to give an error to the github token

I think it seems to suggest the script is ending prematurely. i.e. not syntactically correct.

[mertcanaltin]

Passed 🎉 https://github.com/mertcanaltin/node-auto-test/actions/runs/10972357345/job/30468531837

The issue was that the if block wasn’t properly closed. I just added the missing fi at the end, and now everything works smoothly.

[panva]

Passed 🎉 mertcanaltin/node-auto-test/actions/runs/10972357345/job/30468531837

The issue was that the if block wasn’t properly closed. I just added the missing fi at the end, and now everything works smoothly.

Can you run dispatch with two subsystems? url and WebCryptoAPI. The latter should open a PR.

[mertcanaltin]

https://github.com/mertcanaltin/node-auto-test/actions/runs/10972538059 I ran for both of them

[panva]

https://github.com/mertcanaltin/node-auto-test/actions/runs/10972538059/job/30468925665#step:4:7

It would appear @node-core/utils needs its config file with credentials to run this. Maybe an empty config file would do? I dunno, I'm short on time to look into this.

[RedYetiDev]

You could also move all this logic into a dependency updater script, and call it like the rest of the updaters.

[mertcanaltin]

You could also move all this logic into a dependency updater script, and call it like the rest of the updaters.

ı applied the latest updates, thank you

[mertcanaltin]

You could also move all this logic into a dependency updater script, and call it like the rest of the updaters.

node/.github/workflows/update-openssl.yml

I looked here as an example

[panva]

Look at .github/workflows/auto-start-ci.yml for Setup @node-core/utils

[panva]

I believe the last 2 points weren't addressed. ncu is not configured and the new version variable is used before it is set

[mertcanaltin]

I believe the last 2 points weren't addressed. ncu is not configured and the new version variable is used before it is set

Thanks a lot for your detailed feedback! I’ve now addressed the last two points you mentioned:

I've added a step to configure ncu (node-core-utils) with the necessary GitHub token.
I moved the calculation of the new_version earlier in the workflow to ensure it's set before being referenced.

[panva]

@nodejs/actions please review