test_runner: fix mocking modules with quote in their URL

PR-URL: #55083 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
nodejs · Sep 25, 2024 · aac8ba7 · aac8ba7
1 parent 7d0ce25
commit aac8ba7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/lib/internal/test_runner/mock/loader.js b/lib/internal/test_runner/mock/loader.js
@@ -139,7 +139,7 @@ async function createSourceFromMock(mock, format) {
   const { exportNames, hasDefaultExport, url } = mock;
   const useESM = format === 'module' || format === 'module-typescript';
   const source = `${testImportSource(useESM)}
-if (!$__test.mock._mockExports.has('${url}')) {
+if (!$__test.mock._mockExports.has(${JSONStringify(url)})) {
   throw new Error(${JSONStringify(`mock exports not found for "${url}"`)});
 }
 

diff --git a/test/fixtures/module-mocking/don't-open.mjs b/test/fixtures/module-mocking/don't-open.mjs
@@ -0,0 +1 @@
+export let string = 'original esm string';
diff --git a/test/parallel/test-runner-module-mocking.js b/test/parallel/test-runner-module-mocking.js
@@ -413,6 +413,15 @@ test('modules cannot be mocked multiple times at once', async (t) => {
     t.mock.module(fixture, { namedExports: { fn() { return 42; } } });
     await assert.rejects(import(fixture), { code: 'ERR_UNSUPPORTED_ESM_URL_SCHEME' });
   });
+
+  await t.test('Importing a module with a quote in its URL should work', async (t) => {
+    const fixture = fixtures.fileURL('module-mocking', 'don\'t-open.mjs');
+    t.mock.module(fixture, { namedExports: { fn() { return 42; } } });
+
+    const mocked = await import(fixture);
+
+    assert.strictEqual(mocked.fn(), 42);
+  });
 });
 
 test('mocks are automatically restored', async (t) => {