Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate Splunk Observability release channel #552

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

mkaras-nobl9
Copy link
Contributor

Motivation

Allow to create Splunk Observability Directs in release channel alpha.

Summary

Adds custom validation for the Direct releaseChannel property when using Splunk Observability.

Testing

  • The validation should allow you to create Splunk Observability Direct with the alpha value in the release channel prop. Any other value should fail.
  • Only Splunk Observability Directs can use the alpha release channel.

Release Notes

manifest/v1alpha/direct/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/direct/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/direct/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/direct/validation.go Show resolved Hide resolved
@mkaras-nobl9 mkaras-nobl9 enabled auto-merge (squash) September 24, 2024 09:32
@mkaras-nobl9 mkaras-nobl9 merged commit 5969b3b into main Sep 24, 2024
5 checks passed
@mkaras-nobl9 mkaras-nobl9 deleted the PC-14292-validate-splunk-obs-release-channel branch September 24, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants