feat: Switch back to native yaml decoding #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When recently working on Data Export, we've encountered a problem using
json.RawMessage
withgo-yaml
decoding.The raw message was used to postpone decoding of Data Export spec until we could decide what type should it be decoded to.
Due to time limitations back then we went with the easier solution and decided to use
yaml.YAMLToJSON
, which converts YAML to JSON and then usesencoding/json
to decode the spec.This is not ideal.
Doing it this way we're adding a decoding overhead, that's one thing.
Another, more serious issue is that we're stripping ourselves from receiving detailed syntax errors for YAML.
Instead, we're always getting JSON errors.
By adding
serdeutil
package andRawMessage
which implements both JSON and YAML (un)marshalers we're bringing the aforementioned capabilities back home.Release Notes
Syntax errors when parsing YAML now return more specific details.