Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-11299 Honeycomb query batching enablers - allow setting attribute for COUNT and CONCURRENCY calculation methods #254

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

bdw-nobl9
Copy link
Contributor

@bdw-nobl9 bdw-nobl9 commented Feb 2, 2024

Motivation

Due to changed logic when querying Honeycomb - we're changing how Honeycomb SLOs are defined, allowing now to set the attribute for COUNT and CONCURRENCY calculation methods.

Summary

v1alpha for SLOs is changed - Honeycomb-related code only.

Testing

Try to apply the SLO like

- apiVersion: n9/v1alpha
  kind: SLO
  metadata:
    displayName: count-with-attribute
    name: count-with-attribute
    project: honeycomb
  spec:
    alertPolicies: []
    budgetingMethod: Occurrences
    createdAt: "2023-11-14T11:02:02Z"
    description: The example description
    indicator:
      metricSource:
        kind: Direct
        name: honeycomb
        project: honeycomb
    objectives:
    - countMetrics:
        good:
          honeycomb:
            attribute: latency.good
            calculation: COUNT
        incremental: false
        total:
          honeycomb:
            attribute: latency.total
            calculation: COUNT
      name: objective-1
      target: 0.7
      value: 1
    - countMetrics:
        good:
          honeycomb:
            attribute: latency.good
            calculation: COUNT
        incremental: false
        total:
          honeycomb:
            attribute: latency.total
            calculation: COUNT
      name: objective-2
      target: 0.5
      value: 2
    service: honeycomb
    timeWindows:
    - count: 28
      isRolling: true
      period:
        begin: "2023-12-31T18:26:29Z"
        end: "2024-01-28T18:26:29Z"
      unit: Day

mainly focus on the part containing the attribute for a given objective:

    - countMetrics:
        good:
          honeycomb:
            attribute: latency.good
            calculation: COUNT
        incremental: false
        total:
          honeycomb:
            attribute: latency.total
            calculation: COUNT
      name: objective-1
      target: 0.7
      value: 1

Release Notes

Setting an attribute for COUNT and CONCURRENCY calculation methods is now supported for Honeycomb SLOs.

@bdw-nobl9 bdw-nobl9 force-pushed the honeycomb-enable-count-and-concurrency-attributes branch from 45bde15 to 6e3fd96 Compare February 15, 2024 10:09
@bdw-nobl9 bdw-nobl9 force-pushed the honeycomb-enable-count-and-concurrency-attributes branch from fd357fd to 9a70833 Compare February 19, 2024 08:29
@bdw-nobl9 bdw-nobl9 merged commit 0e1d0f2 into main Feb 19, 2024
5 checks passed
@bdw-nobl9 bdw-nobl9 deleted the honeycomb-enable-count-and-concurrency-attributes branch February 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants