Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filter] util to get nth info #2737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Filter] util to get nth info #2737

wants to merge 1 commit into from
+13 −17

Conversation

jaeyun-jung
Copy link
Contributor

Use util function to get nth tensor-info ptr.
Also, remove unnecessary header include in filter subplugin.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 23, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2737. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@jaeyun-jung jaeyun-jung requested review from EunjuYang and a team as code owners September 23, 2024 06:27
@jaeyun-jung
[Filter] util to get nth info
3e17c39 
Use util function to get nth tensor-info ptr.
Also, remove unnecessary header include in filter subplugin.

Signed-off-by: Jaeyun Jung <[email protected]>
DonghakPark
DonghakPark approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taos-ci
taos-ci approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

djeong20
djeong20 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is it because using the util function is safer than directly accessing nth info?

@jaeyun-jung
Copy link
Contributor Author

jaeyun-jung commented Sep 24, 2024 •
edited
Loading

LGTM! Is it because using the util function is safer than directly accessing nth info?

tensors-info struct has only 16 array slots, others (max number of tensors is 256) are allocated memory.
If the number of tensors are larger than 16, out-of-index error.

@skykongkong8 skykongkong8 mentioned this pull request Sep 26, 2024
Open
@DonghakPark
Copy link
Member

Please Rebase (upstream/main), #2741 resolve cacheLoader_test_case issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@djeong20 djeong20 djeong20 approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn helloahn is a code owner

@kparichay kparichay Awaiting requested review from kparichay kparichay is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit zhoonit is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaeyun-jung @taos-ci @DonghakPark @djeong20 @skykongkong8