[Tizen7.0] PR to support Tizen7.0 #2720
Conversation
- Temporary code for layer initialization Signed-off-by: hyeonseok lee <[email protected]>
Describe a commit content (Until 80 colums per line) in detail ASAP. **Changes proposed in this PR:** - Added TOC generator for README.md Resolves: **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: jijoong.moon <[email protected]>
Describe a commit content (Until 80 colums per line) in detail ASAP. **Changes proposed in this PR:** - Added TOC generator for README.md Resolves: **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: jijoong.moon <[email protected]>
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928 and
songgot
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2720. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
EunjuYang
requested review from
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20 and
a team
as code owners
|
|
cibot:
EunjuYang
force-pushed
the
tizen7.0_backporting
branch
from
96bb3df
to
279e324
Compare
|
|
EunjuYang
force-pushed
the
tizen7.0_backporting
branch
from
279e324
to
c17714d
Compare
There was a problem hiding this comment.
@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.
| @@ -88,6 +88,7 @@ if get_option('enable-fp16') | |||
| # comaptible with armv8.0 machines. | |||
| if cxx.has_argument('-mfp16-format=ieee') | |||
| add_project_arguments('-mfp16-format=ieee', language: ['c', 'cpp']) | |||
| add_project_arguments('-march=armv8.2-a+fp16', language: ['c', 'cpp']) | |||
There was a problem hiding this comment.
could you explain why this change is necessary?
There was a problem hiding this comment.
As far as I know, this option is required to support FP16-SIMD. If this option is missing, it cannot use FP16-SIMD.
packaging/nntrainer.spec
Outdated
| %{_includedir}/nntrainer/util_simd.h | ||
| %if 0%{?enable_fp16} | ||
| %{_includedir}/nntrainer/util_simd_neon.h | ||
| %{_includedir}/nntrainer/blas_neon.h | ||
| %{_includedir}/nntrainer/hgemm.h | ||
| %{_includedir}/nntrainer/hgemm_util.h | ||
| %endif | ||
|
|
There was a problem hiding this comment.
for example,
%ifarch %arm
%{_includedir}/nntrainer/util_simd_neon.h
%{_includedir}/nntrainer/blas_neon.h
%if 0%{?enable_fp16}
%{_includedir}/nntrainer/hgemm.h
%{_includedir}/nntrainer/hgemm_util.h
%endif
%endif
There was a problem hiding this comment.
I think refering to here might be helpful for you
There was a problem hiding this comment.
In the current version, Meson build is designed to support Neon exclusively on AArch64 with FP16 enabled. To maintain consistency, an architectural condition was added before the block. Please examine and review the update.
- This commit adds some updates for Tizen7.0 backporting - Type mismatch bug is fixed. - Unused variable is removed. - Missing header files are added in spec file. - spec file is updated Self evaluation: Build test: [X]Passed [ ]Failed [ ]Skipped Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
force-pushed
the
tizen7.0_backporting
branch
from
c17714d
to
1916f97
Compare
There was a problem hiding this comment.
@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.
This pull request includes the following commits to backport NNTrainer for Tizen 7.0:
This PR is tested with AuXFT example on QRB4210 board (w/ Tizen 7.0).
Self evaluation:
Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped