Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorV2] Add functions to split and concatenate tensors @open sesame 03/07 10:42 #2497

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

djeong20
Copy link
Contributor

@djeong20 djeong20 commented Mar 6, 2024

This pull request adds two new methods to the Tensor class: split() and cat().
The split() method allows users to divide a tensor into multiple smaller tensors along the specified axis.
The cat() method enables them to combine multiple tensors into a single larger tensor along a given axis.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 6, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2497. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@djeong20 djeong20 requested review from skykongkong8, EunjuYang and a team as code owners March 6, 2024 02:38
@taos-ci
Copy link
Collaborator

taos-ci commented Mar 6, 2024

:octocat: cibot: @djeong20, nntrainer/tensor/float_tensor.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djeong20 djeong20 force-pushed the feat/tensor_v2/split_concat branch from e82b6b2 to adc2282 Compare March 6, 2024 03:10
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@DonghakPark DonghakPark changed the title [TensorV2] Add functions to split and concatenate tensors [TensorV2] Add functions to split and concatenate tensors @open sesame 03/07 10:42 Mar 7, 2024
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

This pull request adds two new methods to the Tensor class: split() and cat().
The split() method allows users to divide a tensor into multiple smaller tensors along the specified axis.
The cat() method enables them to combine multiple tensors into a single larger tensor along a given axis.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@djeong20 djeong20 force-pushed the feat/tensor_v2/split_concat branch from adc2282 to 90ff6e9 Compare March 8, 2024 05:04
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 847c552 into nnstreamer:main Mar 11, 2024
30 checks passed
@djeong20 djeong20 deleted the feat/tensor_v2/split_concat branch March 20, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants