[ util ] Use proper STL in max element comparison

- For cleaner code use std::max_element instead of for-loop **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: skykongkong8 <[email protected]>
nnstreamer · Feb 26, 2024 · 94d3328 · 94d3328
1 parent c87da5a
commit 94d3328
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/nntrainer/tensor/tensor.cpp b/nntrainer/tensor/tensor.cpp
@@ -127,8 +127,7 @@ class SrcSharedTensor {
   SrcSharedTensor() : src(nullptr), off(0) {}
 
   SrcSharedTensor(const Tensor *tensor, size_t offset) :
-    src(tensor),
-    off(offset) {}
+    src(tensor), off(offset) {}
 
   /**
    * @brief   Get the allocated src tensor

diff --git a/nntrainer/utils/util_simd.cpp b/nntrainer/utils/util_simd.cpp
@@ -44,13 +44,8 @@ float max(const unsigned int N, float *X) {
 #ifdef USE_NEON
   return nntrainer::neon::max(N, X);
 #else
-  float ret = X[0];
-  unsigned int i = 1;
-  while (i < N) {
-    ret = std::fmax(ret, X[i]);
-    ++i;
-  }
-  return ret;
+  std::vector<float> v(X, X+N);
+  return *std::max_element(v.begin(), v.end());
 #endif
 }
 
@@ -106,13 +101,8 @@ _FP16 max(const unsigned int N, _FP16 *X) {
 #ifdef USE_NEON
   return nntrainer::neon::max(N, X);
 #else
-  _FP16 ret = X[0];
-  unsigned int i = 1;
-  while (i < N) {
-    ret = (ret > X[i]) ? ret : X[i];
-    ++i;
-  }
-  return ret;
+  std::vector<_FP16> v(X, X+N);
+  return *std::max_element(v.begin(), v.end());
 #endif
 }