Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debounce like ezButton. #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

geraldcells18
Copy link

PR for adding debounce. I implement some of ezButton's functions.

@nlamprian
Copy link
Owner

Hi Gerald, thank you for this PR.

Although this repository is very old, and I recognize that the code formatting is ugly, this is not how this issue should be addressed.

Please consider the following:

  • You should not mix changes unrelated to the feature you want to merge in a PR
  • You cannot enforce your own formatting changes without an agreement with the author
  • You should have a clean commit history
  • You should provide a rather verbose description in a PR with a problem statement and your solution

To make it easy on you, let me reformat the code first. Then, you can rebase and focus on the functionality you want to add.

Once again, thank you for the effort; I do appreciate your attention to detail.

@nlamprian
Copy link
Owner

I'm done with the reformatting; feel free to proceed.

@geraldcells18
Copy link
Author

Hey, your library helps me, that's why I am contributing.

This is noted, thank you!

  • You should not mix changes unrelated to the feature you want to merge in a PR
  • You cannot enforce your own formatting changes without an agreement with the author
  • You should have a clean commit history
  • You should provide a rather verbose description in a PR with a problem statement and your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants