Default instructions now specify compiling for release. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangibson14
requested changes
Mar 25, 2020
There was a problem hiding this comment.
I can confirm that this process works, and this is now a good way to suggest people compile. We fixed the problem fast enough, that it seems silly to have changed the website.
My request, though: Because this process only works for 1.1.1 and not previous versions, we should include a note somewhere saying "If you use an older version's signature file, you may need to omit the -D CMAKE_BUILD_TYPE=Relase from the CMake command."
|
Thanks for the suggestion @nathangibson14 I've added a comment and fixed some spelling errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.