Skip to content

Commit

Permalink
Merge pull request #107 from njoy/bugfix/uninitialized
Browse files Browse the repository at this point in the history
Adding pragma to work around GCC 'bug'.
  • Loading branch information
jlconlin authored Mar 25, 2020
2 parents 7f47006 + e320bac commit a3d5815
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions ReleaseNotes.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Release Notes—NJOY21
Given here are some release notes for NJOY21. Each release is made through a formal [Pull Request](https://github.com/njoy/NJOY21/pulls) made on GitHub. There are links in this document that point to each of those Pull Requests, where you can see in great details the changes that were made. Often the Pull Requests are made in response to an [issue](https://github.com/njoy/NJOY21/issues). In such cases, links to those issues are also given.

## [NJOY21 1.1.1](https://github.com/njoy/NJOY21/pull/107)
This update fixes an issue where GCC would complain about a "maybe" uninitialized variable in [lipservice](https://github.com/njoy/lipservice). This only happens when compiled in release mode with GCC. Using the clang/LLVM compiler does not invoke this warning/error.

This update address issue #106.

## [NJOY21 1.1.0](https://github.com/njoy/NJOY21/pull/104)
This update moves the C++ standard to C++17; thus, a c++17-compliant compiler is needed to build NJOY21. Fortunately, C++17-compliant compilers have been available for several years.

Expand Down
6 changes: 5 additions & 1 deletion src/njoy21.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
#include "dimwits.hpp"
#include "Log.hpp"
#include "utility.hpp"
#include "lipservice.hpp"

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#include "lipservice.hpp"
#pragma GCC diagnostic pop

#include "njoy_c.h"

Expand Down
2 changes: 1 addition & 1 deletion src/njoy21/Version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Version{
// Change whenever new capability is implemented
static constexpr int minorVersion{1};
// Change whenever merge to master branch is done
static constexpr int patchVersion{0};
static constexpr int patchVersion{1};

static std::string version(){
return std::to_string( majorVersion ) + "." +
Expand Down

0 comments on commit a3d5815

Please sign in to comment.