Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$args = $args[0] ; #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

$args = $args[0] ; #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function run()
}
Yii::endProfile('service.request');

Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
//Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;

return $this->toJson();
}
Expand Down
3 changes: 3 additions & 0 deletions traits/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ public function getParams($method)
{
$params = [];
$args = isset($this->_data['params']) ? $this->_data['params'] : [];

if(isset($args[0]) && is_array($args[0])) $args = $args[0];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
This line doesn't follow JSON RPS 2.0 specification:
https://www.jsonrpc.org/specification#request_object

by-position: params MUST be an Array, containing the values in the Server expected order.
not first element inside params must be Array, but params itself must be an array.


foreach ($method->getParameters() as $param) {
/* @var $param ReflectionParameter */
if (isset($args[$param->getName()])) {
Expand Down