Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: structure related with icon #21

Merged
merged 1 commit into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/portfolio/src/components/Header.astro
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
import Links from '../core/links.js';
import { listIconPath } from '../icon-path.js';
import Button from './Button.astro';
import InternalLink from './InternalLink.astro';
import { listIconPath } from './svgs/icons/icon-path.js';

export type { Props as HeaderProps };

Expand Down Expand Up @@ -69,7 +69,7 @@ const NAV_ID = 'nav-menu';
</header>

<script>
import { listIconPath, xIconPath } from '../icon-path.js';
import { listIconPath, xIconPath } from './svgs/icons/icon-path.js';

const OPEN_NAV_BUTTON_ID = 'open-nav-button';

Expand Down
2 changes: 1 addition & 1 deletion apps/portfolio/src/components/WorkCard.astro
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Image } from 'astro:assets';
import { getEntries } from 'astro:content';
import Links from '../core/links.js';
import InternalLink from './InternalLink.astro';
import TechIcon from './icons/TechIcon.astro';
import TechIcon from './svgs/icons/TechIcon.astro';

import type { CollectionEntry } from 'astro:content';

Expand Down
8 changes: 4 additions & 4 deletions apps/portfolio/src/components/pages/index/About.astro
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
import EnvelopeSimpleIcon from '../../icons/EnvelopeSimpleIcon.astro';
import GitHubIcon from '../../icons/GitHubIcon.astro';
import PencilSimpleLineIcon from '../../icons/PencilSimpleLineIcon.astro';
import EnvelopeSimpleIcon from '../../svgs/icons/EnvelopeSimpleIcon.astro';
import GitHubIcon from '../../svgs/icons/GitHubIcon.astro';
import PencilSimpleLineIcon from '../../svgs/icons/PencilSimpleLineIcon.astro';

import type { IconProps } from '../../icons/types.js';
import type { IconProps } from '../../svgs/types.js';

interface Props {
class?: string | null;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
// From: https://github.com/phosphor-icons/core/blob/c67d7a849f450be1bfe64fd5820471e4019e5ff0/assets/regular/envelope-simple.svg

import type { IconProps } from './types.js';
import type { IconProps } from '../types.js';

type Props = IconProps;
---
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
// From: https://github.com/devicons/devicon/blob/5615b6091fea770fdf7d6160d8d7056cf1130c03/icons/github/github-original.svg

import type { IconProps } from './types.js';
import type { IconProps } from '../types.js';

type Props = IconProps;
---
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
// From: https://github.com/phosphor-icons/core/blob/c67d7a849f450be1bfe64fd5820471e4019e5ff0/assets/regular/pencil-simple-line.svg

import type { IconProps } from './types.js';
import type { IconProps } from '../types.js';

type Props = IconProps;
---
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
import type { IconProps } from './types.js';
import type { IconProps } from '../types.js';

interface Props extends IconProps {
icon: string;
Expand Down