Add support for specifying the screens of panels #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52.
This solution is a bit hacky, but essentially how it works is that if the user specifies any non-default screen for any of the panels, we create an immutable entry for
lastScreenfor the panel, then restart the plasmashell after thelastScreenkey has been made immutable. This was the only way I could figure out to make kde not change thelastScreenkey all the time. It also was not possible to write immutable entries directly from plasma-scripts, so this was the best solution I could come up with. There is a lot of room for improvement on the plasma side here I reckon, so hopefully some time in the future a more elegant solution is possible, but this should do the job in the meantime (as it is fully functional at the very least).If no custom screen is set for any of the panels everything works exactly like it did before this pr, which makes this a fairly safe and good solution I think.