apps: make package installation optional #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users should be able to configure a system-wide installation of
`{kate,ghostwriter,okular}` without needing to have a duplicate home
manager package. This behaviour was even documented in Kate's `package`
option, but did not work as the `nullable` tag wasn't set to true. This
commit corrects this behaviour.
Signed-off-by: Fernando Rodrigues <[email protected]>
|
Really good change! Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should be able to configure a system-wide installation of
{kate,ghostwriter,okular}without needing to have a duplicate home manager package. This behaviour was even documented in Kate'spackageoption, but did not work as thenullabletag wasn't set to true. This commit corrects this behaviour.